[Openjmx-devel] HTTPAdaptor management interface

[Bordet, Simone]

Hi Carlos,

I'm integrating the SSL support, and take a look to the management interface of the HTTPAdaptor, and I have some question:

1) setProcessorName takes an ObjectName. IMHO should take a String, in order to be useful for the management interface, otherwise from the adaptor you cannot stop(), change the processor name, and start() it again, since you cannot create ObjectName and pass them to the adaptor. Am I missing something ?
2) restart(). Isn't enough to have start() and stop() ? For consistency changing parameters when the adaptor is running should not be done. For example, you start the adaptor, then you go to the management interface and change the port, then you forget to restart() it. Another user will see the new port, but in reality it is still running on the old one... IMHO start() and stop() should do the job.

Simon

[Carlos Quiroz]

Post by Bordet, Simone
Hi Carlos,
I'm integrating the SSL support, and take a look to the management
1) setProcessorName takes an ObjectName. IMHO should take a String, in
order to be useful for the management interface, otherwise from the adaptor
you cannot stop(), change the processor name, and start() it again, since
you cannot create ObjectName and pass them to the adaptor. Am I missing
something ?

The HttpAdaptor can accept ObjectName parameters.

2) restart(). Isn't enough to have start() and stop() ? For

Post by Bordet, Simone
consistency changing parameters when the adaptor is running should not be
done. For example, you start the adaptor, then you go to the management
interface and change the port, then you forget to restart() it. Another
user will see the new port, but in reality it is still running on the old
one... IMHO start() and stop() should do the job.

So you suggest to throw an exception when some parameter like port and host
are modified

Post by Bordet, Simone
Simon
_______________________________________________
Openjmx-devel mailing list
https://lists.sourceforge.net/lists/listinfo/openjmx-devel

[Bordet, Simone]

Hi,

Post by Bordet, Simone

Post by Bordet, Simone
1) setProcessorName takes an ObjectName. IMHO should take a

String, in

Post by Bordet, Simone
order to be useful for the management interface, otherwise

from the adaptor

Post by Bordet, Simone
you cannot stop(), change the processor name, and start()

it again, since

Post by Bordet, Simone
you cannot create ObjectName and pass them to the adaptor.

Am I missing

Post by Bordet, Simone
something ?

The HttpAdaptor can accept ObjectName parameters.

Great, I didn't know :)
Of course won't work with other less advanced http adaptors, but ok for me.

Post by Bordet, Simone
2) restart(). Isn't enough to have start() and stop() ? For

Post by Bordet, Simone
consistency changing parameters when the adaptor is running

should not be

Post by Bordet, Simone
done. For example, you start the adaptor, then you go to

the management

Post by Bordet, Simone
interface and change the port, then you forget to restart()

it. Another

Post by Bordet, Simone
user will see the new port, but in reality it is still

running on the old

Post by Bordet, Simone
one... IMHO start() and stop() should do the job.

So you suggest to throw an exception when some parameter like
port and host are modified

Or throw some exception or do nothing, maybe better the former.
I have the same issue for the RMI adaptor, for now I check isRunning() and do nothing if it is...

So restart() can be removed yes ?

Please wait to do this change, as I'm integrating SSL on the HTTP adaptor. I will commit soon.

Simon